1. PyPA
  2. Python Packaging Authority Projects
  3. setuptools
  4. Pull requests

Pull requests

#26 Merged at ef7fd69
Repository
Deleted repository
Branch
default (2b804cefb64e)
Repository
setuptools
Branch
default

SVN Encoding Issues

Author
  1. philip_thiem
Reviewers
Description

This should fix issue #113 and #105.

Basically for determining the terminal encoding:

  1. Try getpreferredencoding
  2. If that is US_ASCII or None try the encoding from getdefaultlocale() if that was a "fallback" because python couldn't figure it out from the environment or OS, this wll result in None.
  3. If not none, then make sure python actually knows about the encoding.
  4. On the event of an error or unknown codec, revert to fallbacks
  5. This is on darwin try utf-8 everything else ASCII. Also on the darwin and mac-roman, switch to utf-8 this was a bug on older pythons.

On a side note, it would seem that the encoding only matters for when a version of svn doesn't yet support --xml and for getting repository and svn versions numbers. The --xml should be utf8 per some messages on the SVN mailing lists. So if the version number are always 7-bit ASCII clean, it may be best to only support the file parsing methods for legacy SVNs, and support for svn without the command would simple go away as support for the older SVNs does.

Comments (0)