Pull requests

#32 Merged
Repository
qwcode
Branch
zip_path
Repository
pypa
Branch
default

convert "find_in_zip" into "find_eggs_in_zip" to prevent it from walking whl files

Author
  1. Marcus Smith
Reviewers
Description

a possible solution for https://bitbucket.org/pypa/setuptools/issue/129

find_in_zip is not for wheels (at least not right now), but wheels are getting sent through it

In most cases, find_in_zip just finds no dists in wheel zips, but when wheels are nested under an egg dir, we see the failure in #129

the failure is caused by this code: https://bitbucket.org/pypa/setuptools/src/735202ca6848d58bc59022f85cde10af64a61a7e/pkg_resources.py?at=default#cl-1383

this code ends up constructing the zip path using the virtualenv egg root (which contains the setuptools wheel), and not the setuptools whl file as the root, which leads to the assertion error we see. I was tempted to alter this bit of code, but it's all very egg-assumptive, and the cleaner fix seemed to be to not let wheels enter this path at all.

I'm willing to add a test too, if people agree with this.

Comments (1)