1. PyPA
  2. Python Packaging Authority Projects
  3. setuptools
  4. Pull requests

Pull requests

#52 Declined
Repository
jurko
Branch
generalized-fix-for-issue-197
Repository
pypa
Branch
default

generalize fix for issue #197 from 1cd816bb7c933eecd9d8464e054b21c7d5daf2df

Author
  1. Jurko Gospodnetić
Reviewers
Description

Commit 1cd816bb7c933eecd9d8464e054b21c7d5daf2df works around the non-ASCII character issue #197 for Python version 3.1. This pull request #52 applies the same workaround for Python version range [3.0 - 3.2.2>.

See issue #197 and related comments on commit 1cd816bb7c933eecd9d8464e054b21c7d5daf2df for more background information.

Comments (5)

  1. Jurko Gospodnetić author

    Jason R. Coombs could you please confirm that it's ok for me to go ahead and commit this?

    I'd really like for it to be included in the next non-beta release - makes my life simpler as with it I can remove some post-installation patching code in some of my projects. smile Thanks.

    Best regards, Jurko Gospodnetić

  2. Jason R. Coombs

    I would say just merge it, except I really do want to avoid adding branches to the mercurial repo for short-lived efforts such as this. I'll rebase the change to the latest master, though.

      1. Jason R. Coombs

        Yes, please. I haven't had the time to figure out exactly what to recommend as pull requests go, but for most pull requests, using the default branch would be preferable. Thanks.