Matti Picus avatar Matti Picus committed 30cad22

skip hanging SIGINT test on windows

Comments (3)

  1. Brian Kearns

    if you're running the tests on pypy/module/pypy by hand, you can know they fail with a lock, so you can interrupt them/selectively run tests you want.

    if it's running in the buildbot, it will timeout and be killed. tests will continue on other directories.

    so given these two cases i don't see any reason to go around skipping tests that timeout. additionally, this skip is applied to cases where the test was passing, which seems even more odd/careless.

  2. Brian Kearns

    if you care enough about seeing results for the dir in the buildbot without fixing the issue locking this test, the proper thing seems to be to improve the test so that it times itself out, not to apply a general skip to this test, something easily forgotten.

Files changed (1)


     def test_enable_signals(self):
+        import sys
+        if sys.platform.startswith('win'):
+            skip('signals not operable on windows')
         import __pypy__, thread, signal, time
         def subthread():
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.