Pull requests

#100 Merged
Repository
Deleted repository
Branch
default (bdc4935c090b)
Repository
pypy/pypy pypy
Branch
default

replace some obsolete use of time with rctime, more test_ioctl fixes

Author
  1. Brian Kearns
Reviewers
Description

results in many unnecessary applevel test skips

http://doc.pypy.org/en/latest/config/objspace.usemodules.time.html

s module/thread/test/test_fork.py::AppTestFork::()::test_fork
Skipped: cannot runappdirect test: module 'time' required
s module/thread/test/test_fork.py::AppTestFork::()::test_forked_can_thread
Skipped: cannot runappdirect test: module 'time' required
s module/thread/test/test_import_lock.py::AppTestThread::()::test_import_lock
Skipped: cannot runappdirect test: module 'time' required
...

and added in some more test_ioctl fixes

  • Learn about pull requests

Comments (3)

  1. Brian Kearns author

    and is silently skipping when a specified usemodules module isn't found really a good failure mode?

    also, more generally, i find skips are pretty loosely applied in tests, seems like it could lead to many silent skips which open up bugs. ie if not hasattr (mod, func): skip (fork doesnt exist on windows or whatever) rather than testing/skipping based on platform directly (doesn't fail, would just start skipping if os.fork happened to disappear on linux). fine for app level code, but really seems like too much inference for a test suite. do you think it's worth cleaning things like this up?