1. PyPy
  2. PyPy project
  3. pypy
  4. Pull requests

Pull requests

#224 Merged at 4c3f063
Repository
groggi
Branch
latest-improve-doc
Repository
pypy
Branch
default

PyPy Docs: fighting broken links #2

Author
  1. Gregor Wegberg
Reviewers
Description

I found out about linkcheck, felt like my last PR didn't finish the work I started and I sat in a very uninteresting (i.e. boring) lecture. This is the result.

Result of the patches: http://groggi-latest-pypy-docs.readthedocs.org/

I ignored all the release-*.rst files and there are still some broken links I don't know how to fix:

writing output... [ 71%] eventhistory
(line  215) broken    http://codespeak.net/~hpk/heidelberg-sprint/ - HTTP Error 404: Not Found
(line  233) broken    http://codespeak.net/~hpk/hildesheim2-sprint-www/hildesheim2-sprint-www-Thumbnails/36.jpg - HTTP Error 404: Not Found
(line  233) broken    http://codespeak.net/~hpk/hildesheim2-sprint-www/hildesheim2-sprint-www-Pages/Image37.html - HTTP Error 404: Not Found
(line  233) broken    http://codespeak.net/~hpk/hildesheim2-sprint-www/ - HTTP Error 404: Not Found
writing output... [ 96%] stm
(line   32) broken    http://buildbot.pypy.org/nightly/stmgc-c7/ - HTTP Error 404: Not Found
writing output... [ 95%] statistic/index
(line   61) broken    http://codespeak.net/pypy/ - HTTP Error 404: Not Found

Comments (7)

  1. Armin Rigo

    stm.rst is in-progress, I'll make sure the links are valid.

    The ~hpk links need to disappear, I fear.

    The links to pypy/objspace/std/*type.py can be replaced with pypy/objspace/std/*object.py.

    The link to pypy/objspace/flow/ can be replaced with rpython/flowspace.

    The link to http://codespeak.net/pypy/ is simply http://pypy.org/ nowadays.

    1. Gregor Wegberg author

      Great, thank you for the comments. I'm going to create patches according to your comment. If the PR is still open, I'm going to update it or otherwise create a new one.

  2. Gregor Wegberg author

    Ok, all changes done as far as I see it. According to linkcheck only old release-*.rst and the statistics page (as expected) contain broken links now. I don't think it makes sense to fix release-*.rst files. They are only of historical interest and spending time to fix them makes no sense right now to be honest.

    The result of this PR can be seen over at https://groggi-latest-pypy-docs.readthedocs.org/en/latest/ and https://readthedocs.org/builds/groggi-latest-pypy-docs/ for build information.

    Please take a good look at the changes in

    • coding-guide.rst: removed a whole section as I think it is not relevant anymore and may confuse people
    • statistic/index.rst: please check the grammar, I'm not a very good writer and English isn't my native language
    • eventhistory.rst: please check the grammar here too. I had to remove parts of the text because of the lost pictures
  3. Armin Rigo

    Ok, seems good now. I'll merge it and then fix a couple of sentences myself in objspace.rst which still talk about the distinction between xxxobject.py and xxxtype.py.