1. PyPy
  2. PyPy project
  3. pypy
  4. Pull requests

Pull requests

#23 Merged
Repository
Deleted repository
Branch
default (fd6e2144e652)
Repository
pypy
Branch
default

Fix _sqlite3.py fix for issue996, with test

Author
  1. David Ripton
Reviewers
Description

4 commits of trivial cleanups to lib_pypy/_sqlite3.py, a comment to comply with the pysqlite license, a test based on the test case in issue996, and a one-line fix for issue996. lib-python/2.7/test/test_sqlite.py still passes after the change.

Added an assert to the new test, which previously just looked for exceptions.

Comments (3)

  1. Alex Gaynor

    A few comments:

    1. No need for the new comment at the top of _sqlite3.py, it has already been modified many times :)
    2. The new tests should probably make an assertion about the contents of result, even if it's just that it's an empty list.

    Thanks!

  2. David Ripton author

    Alex, the new comment is there because the pysqlite license specifically requires that modified versions be marked as modified. It's a silly requirement, but it should be obeyed. I will add an assert to the test.