1. Pypy
  2. Untitled project
  3. pypy
  4. Pull requests

Pull requests

#63 Declined
Repository
MichaelBlume
Branch
ndmin
Repository
pypy
Branch
default

add ndmin param to numpy.array

Author
  1. Michael Blume
Reviewers
Description

Two things that need review here. First, I'm doing array multiplication, and I'm not sure that's allowed in RPython code. Second, I'm checking whether w_ndmin is either a None or a wrapped-none, which seems a little smelly. Suggestions welcome.

Comments (1)

  1. Maciej Fijalkowski

    list multiplication is fine, also test_ztranslation (mostly) checks if this is correct rpython. the None or a wrapped-none is only necessary if you call array from somewhere else in the interp-level (since then there is no automagic wrapping).

    Can you please merge in default and resolve the (mostly trivial, but not quite) conflict first though?

    Cheers, fijal