pypy / pypy / module / _posixsubprocess /

Full commit
from pypy.translator.goal import autopath
from pypy.rpython.lltypesystem import rffi, lltype, llmemory
from pypy.module.posix.interp_posix import fsencode_w, run_fork_hooks
from pypy.interpreter.gateway import unwrap_spec
from pypy.interpreter.error import (
    OperationError, exception_from_errno, wrap_oserror)
from pypy.translator.tool.cbuild import ExternalCompilationInfo
import py
import os

pypydir = py.path.local(autopath.pypydir)
thisdir = pypydir.join('module', '_posixsubprocess')

eci = ExternalCompilationInfo(
c_child_exec = rffi.llexternal(
    [rffi.CCHARPP, rffi.CCHARPP, rffi.CCHARPP, rffi.CCHARP,
     rffi.INT, rffi.INT, rffi.INT, rffi.INT, rffi.INT, rffi.INT, 
     rffi.INT, rffi.INT, rffi.INT, rffi.INT, rffi.INT,
     rffi.CArrayPtr(rffi.LONG), lltype.Signed,
     lltype.Ptr(lltype.FuncType([rffi.VOIDP], rffi.INT)), rffi.VOIDP],
c_cloexec_pipe = rffi.llexternal(
    [rffi.CArrayPtr(rffi.LONG)], rffi.INT,

class PreexecCallback:
    def __init__(self): = None
        self.w_preexec_fn = None
    def run_function(unused):
        self = preexec
        if self.w_preexec_fn:
            except OperationError:
                return 0
        return 1
preexec = PreexecCallback()

def build_fd_sequence(space, w_fd_list):
    result = [space.int_w(w_fd)
              for w_fd in space.unpackiterable(w_fd_list)]
    prev_fd = -1
    for fd in result:
        if fd < 0 or fd < prev_fd or fd > 1 << 30:
            raise OperationError(space.w_ValueError, space.wrap(
                    "bad value(s) in fds_to_keep"))
    return result

@unwrap_spec(p2cread=int, p2cwrite=int, c2pread=int, c2pwrite=int,
             errread=int, errwrite=int, errpipe_read=int, errpipe_write=int,
             restore_signals=int, call_setsid=int)
def fork_exec(space, w_process_args, w_executable_list,
              w_close_fds, w_fds_to_keep, w_cwd, w_env_list,
              p2cread, p2cwrite, c2pread, c2pwrite,
              errread, errwrite, errpipe_read, errpipe_write,
              restore_signals, call_setsid, w_preexec_fn):
    fork_exec(args, executable_list, close_fds, cwd, env,
              p2cread, p2cwrite, c2pread, c2pwrite,
              errread, errwrite, errpipe_read, errpipe_write,
              restore_signals, call_setsid, preexec_fn)

    Forks a child process, closes parent file descriptors as appropriate in the
    child and dups the few that are needed before calling exec() in the child
    The preexec_fn, if supplied, will be called immediately before exec.
    WARNING: preexec_fn is NOT SAFE if your application uses threads.
             It may trigger infrequent, difficult to debug deadlocks.
    If an error occurs in the child process before the exec, it is
    serialized and written to the errpipe_write fd per
    Returns: the child process's PID.
    Raises: Only on an error in the parent process.
    close_fds = space.is_true(w_close_fds)
    if close_fds and errpipe_write < 3:  # precondition
        raise OperationError(space.w_ValueError, space.wrap(
                "errpipe_write must be >= 3"))
    fds_to_keep = build_fd_sequence(space, w_fds_to_keep)

    # No need to disable GC in PyPy:
    # - gc.disable() only disables __del__ anyway.
    # - appelvel __del__ are only called at specific points of the
    #   interpreter.

    l_exec_array = lltype.nullptr(rffi.CCHARPP.TO)
    l_argv = lltype.nullptr(rffi.CCHARPP.TO)
    l_envp = lltype.nullptr(rffi.CCHARPP.TO)
    l_cwd = lltype.nullptr(rffi.CCHARP.TO)
    l_fds_to_keep = lltype.nullptr(rffi.CArrayPtr(rffi.LONG).TO)

    # Convert args and env into appropriate arguments for exec()
    # These conversions are done in the parent process to avoid allocating
    # or freeing memory in the child process.
        exec_array = [space.bytes_w(w_item)
                      for w_item in space.listview(w_executable_list)]
        l_exec_array = rffi.liststr2charpp(exec_array)

        if not space.is_none(w_process_args):
            argv = [fsencode_w(space, w_item)
                    for w_item in space.listview(w_process_args)]
            l_argv = rffi.liststr2charpp(argv)

        if not space.is_none(w_env_list):
            envp = [space.bytes_w(w_item)
                    for w_item in space.listview(w_env_list)]
            l_envp = rffi.liststr2charpp(envp)

        l_fds_to_keep = lltype.malloc(rffi.CArrayPtr(rffi.LONG).TO,
                                      len(fds_to_keep) + 1, flavor='raw')
        for i in range(len(fds_to_keep)):
            l_fds_to_keep[i] = fds_to_keep[i]

        # if not space.is_none(w_preexec_fn):
        #     _PyImport_AcquireLock() = space
        preexec.w_preexec_fn = w_preexec_fn

        if not space.is_none(w_cwd):
            cwd = fsencode_w(space, w_cwd)
            l_cwd = rffi.str2charp(cwd)

            pid = os.fork()
        except OSError, e:
            raise wrap_oserror(space, e)

        if pid == 0:
            # Child process
            # Code from here to _exit() must only use
            # async-signal-safe functions, listed at `man 7 signal`
            if not space.is_none(w_preexec_fn):
                # We'll be calling back into Python later so we need
                # to do this. This call may not be async-signal-safe
                # but neither is calling back into Python.  The user
                # asked us to use hope as a strategy to avoid
                # deadlock...
                run_fork_hooks('child', space)

                l_exec_array, l_argv, l_envp, l_cwd,
                p2cread, p2cwrite, c2pread, c2pwrite,
                errread, errwrite, errpipe_read, errpipe_write,
                close_fds, restore_signals, call_setsid,
                l_fds_to_keep, len(fds_to_keep),
                PreexecCallback.run_function, None)

    # parent process
        # if not space.is_none(w_preexec_fn):
        #     _PyImport_ReleaseLock()
        run_fork_hooks('parent', space)
        preexec.w_preexec_fn = None

        if l_cwd:
  , flavor='raw')
        if l_envp:
  , flavor='raw')
        if l_argv:
  , flavor='raw')
        if l_exec_array:
  , flavor='raw')
        if l_fds_to_keep:
  , flavor='raw')

    return space.wrap(pid)

def cloexec_pipe(space):
    """"cloexec_pipe() -> (read_end, write_end)
    Create a pipe whose ends have the cloexec flag set."""

    with lltype.scoped_alloc(rffi.CArrayPtr(rffi.LONG).TO, 2) as fds:
        res = c_cloexec_pipe(fds)
        if res != 0:
            raise exception_from_errno(space, space.w_OSError)

        return space.newtuple([space.wrap(fds[0]),