Anonymous avatar Anonymous committed 327f8ac

Turns out that calling close() in __del__() is wrong: when the

caller uses makefile() and releases the socket object itself,

the underlying socket and streams should *not* be closed, as

they are still in use by the file object returned by makefile().

Comments (0)

Files changed (1)

 	else:
 	    raise IOError, "both istream and ostream have been shut down"
 
-    def __del__(self):
-	self.close()
-
     def shutdown(self, how):
 	assert how in (0, 1, 2)
 	assert self.sock
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.