Issue #5 resolved

duic generating incorrect connection functions for signals and slots

Michael Crompton
created an issue
 <connections>
  <connection>
   <sender>buttonBox</sender>
   <signal>accepted()</signal>
   <receiver>Dialog</receiver>
   <slot>accept()</slot>
 </connection>

from the ui files was generated as

buttonBox.accepted.connect(&Dialog.accept);

Im not sure if this is how it worked for D1

but based on some of the examples in the examples folder, it appears that the output needs to be this for D2

Dialog.connect(buttonBox, "accepted", Dialog, "accept");

I think fixed this problem and attached my fix. I'm not too familiar with qtd, so please review.

Comments (5)

  1. Eldar Insafutdinov

    Hi Mike. The patch looks allright except for the part where you pass parentWidget into the function. That shouldn't be necessary, because QObject.connect is a static function and you don't need an instance of a class to be able to call it, so the patch should be a lot simpler.

  2. Log in to comment