Aristarkh Zagorodnikov avatar Aristarkh Zagorodnikov committed 9f33a55

Added reuse of brigade during auto-retry

Comments (0)

Files changed (1)

gridfs/mod_gridfs.cpp

 						ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO, 0, request, "mod_gridfs: No chunks available for file '%s'.", filename); 
 						return HTTP_INTERNAL_SERVER_ERROR;
 					}
-					brigade = apr_brigade_create(request->pool, request->connection->bucket_alloc);
 					if (brigade == 0)
 					{
-						connection->done();
-						ap_log_rerror(APLOG_MARK, APLOG_CRIT, 0, request, "mod_gridfs: Failed to create brigade."); 
-						return HTTP_INTERNAL_SERVER_ERROR;
+						brigade = apr_brigade_create(request->pool, request->connection->bucket_alloc);
+						if (brigade == 0)
+						{
+							connection->done();
+							ap_log_rerror(APLOG_MARK, APLOG_CRIT, 0, request, "mod_gridfs: Failed to create brigade."); 
+							return HTTP_INTERNAL_SERVER_ERROR;
+						}
 					}
 					for (int chunk_index = 0;chunk_index < num_chunks;chunk_index++) 
 					{
 				}
 			}
 			if (brigade != 0)
-			{
-				apr_brigade_destroy(brigade);
-				brigade = 0;
-			}
+				apr_brigade_cleanup(brigade);
 			apr_sleep(RETRY_DELAY * 1000);
 		}
 		if (content_length != 0)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.