1. Martin Felis
  2. rbdl
  3. Pull requests

Pull requests

#4 Declined
Repository
thomas_moulard
Branch
default
Repository
rbdl
Branch
default

Make RBDL Debian compatible

Author
  1. Thomas Moulard
Reviewers
Description

Dear Martin, here are the modification I had to apply on the release so that I can package RBDL.

Can you incorporate them if possible?

Comments (6)

  1. Martin Felis

    Hi Thomas, thanks for your pull request and debianizing rbdl.

    Unfortunately it fails to compile on my system as addons/luamodel/luatables.h cannot find config.h.

    Furthermore, is there a reason to use PKG_CHECK_MODULES instead of the standard CMake facilities?

    1. Thomas Moulard author

      On Thu, Aug 01, 2013 at 11:54:01AM -0000, Martin Felis wrote:

      I will look into this. Can you provide me with the exact error message? (and your current distribution). It may because Lua is not having exactly the same behavior on your local distribution.

      I prefer pkg-config over the CMake modules as the latter breaks easily and is CMake specific. The other is used by all the buildchain tools making the pkg-config quite tested and reliable. However, in this case, if it fixes our problem then I am not against using it. It is just my default tool.

      Best,

      Thomas

      1. Martin Felis

        I am using Ubuntu 12.04. The error is:

        In file included from [...]/projects/rbdl/moulard/addons/luamodel/luamodel.cc:2:0:
        [...]/projects/rbdl/moulard/addons/luamodel/luamodel.h:3:20: fatal error: config.h: No such file or directory
        compilation terminated.
        make[2]: *** [addons/luamodel/CMakeFiles/rbdl_luamodel.dir/luamodel.cc.o] Error 1
        make[1]: *** [addons/luamodel/CMakeFiles/rbdl_luamodel.dir/all] Error 2
        make: *** [all] Error 2
        

        I guess a simple include gate using #ifdef HAVE_CONFIG_H should be sufficient. Which config.h is meant to be included?

  2. Martin Felis

    Hi Thomas,

    I have incorporated your changes in https://bitbucket.org/MartinFelis/rbdl-debianize along with the following adjustments:

    • use CMake scripts to find UnitTest++ and Lua5.1 instead of PkgConfig
    • use rbdl_config.h in the luamodel and urdfreader addon instead of their on config.h
    • removed sources of Lua and UnitTest++ as we use the system's versions anyway
    • removed commented rpath settings form CMakeLists.txt

    Can you take a brief look at the changes? Furthermore: should I increase the version number to 2.1 for all these changes? I guess it does break linking.

    Thanks for your time and efforts!

  3. Thomas Moulard author

    Seems good to me. Yes, please merge and release if possible. I will directly put this release into Debian so that it will minimize the Debian specific patches on top of RBDL. And yes, this is a non ABI-compatible changes so please update to 2.1.

    Thank you!