Commits

Armin Rigo committed 7d05feb

Comment, and kill outdated method (see start_transaction() in
the class StmShadowStackRootWalker).

Comments (0)

Files changed (2)

pypy/rlib/rstm.py

 def _stm_run_transaction(transactionptr, retry_counter):
     #
     # Tell the GC we are starting a transaction
+    # (at this point, we have no stack root at all; the following
+    # call will clear any remaining garbage from the shadowstack,
+    # in case of an aborted transaction)
     llop.stm_start_transaction(lltype.Void)
     #
     # Now we can use the GC

pypy/rpython/memory/gctransform/stmframework.py

         self.rootstackhook(collect_stack_root, arg,
                            stackgcdata.root_stack_base,
                            stackgcdata.root_stack_top)
-
-    def clear_current_stack_roots(self):
-        """Used when we start a transaction: there might be garbage left
-        behind by the previous aborted transaction."""
-        stackgcdata = self.stackgcdata
-        stackgcdata.root_stack_top = stackgcdata.root_stack_base
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.