- changed status to open
- removed comment
GRHydro_InitData updates
Attached please find the accumulated updates to GRHydro_InitData from Zelmani. Allmost of them affect MHD only. The only exception is the patch that REQUIREs EOS_Omni.
There are some few patches I did not push since they involve the hot EOS which is currently being worked on.
Unless there are objections I will apply them on Wednesday afteroon.
Keyword: GRHydro_InitData
Comments (7)
-
reporter -
- removed comment
Is it necessary to attach the test data patch? I would have thought that code change patch was sufficient, along with a comment "test data will be regenerated".
-
- removed comment
It is nice to ensure that everybody will generate the same test data.
-
reporter - removed comment
Actually patch 0001 manages to be above 256k even without test data. 256 is just a bit small it seems. Of course one could argue that one should not generate such big patches and rather have several smaller commits (unless it is something where the patch is huge because files were renamed) but that I think is a different can of worms :-)
-
- removed comment
Replying to [comment:3 eschnett]:
It is nice to ensure that everybody will generate the same test data.
How is this different from running the tests after the data has been committed?
-
- removed comment
It allows testing the patch before it is committed. That is, I can apply the patch and e.g. test it on a strange machine or strange architecture.
Of course, in reality I trust the patch author, will only read the patch, comment on the general approach taken to address a particular problem, and if there is indeed a problem it will be picked up after it has been applied. In most cases this will be fine.
-
reporter - changed status to resolved
- removed comment
all applied in rev 134 to 150.
- Log in to comment
attached patches. combined.patch.gz contains the whole set (and is too large to attach uncompressed). 0001 comes in part1 and part2 since trac will not let me attach it as a whole since it is too large.