- changed status to open
- removed comment
New thorn ML_WaveToy_Test
I propose to add a new thorn ML_WaveToy_Test to the Einstein Toolkit. This thorn exists in the McLachlan arrangement and complements the auto-generated McLachlan/ML_WaveToy with test cases.
Keyword:
Comments (6)
-
reporter -
- removed comment
Is there a reason why these tests cannot be implemented for ML_BSSN instead?
-
reporter - removed comment
No, there is no reason, except that maybe scalar waves are easier to debug and faster to run.
-
- removed comment
Right, but we are talking about regression tests here, so maybe having a more "complicated" system is more likely to pick up problems. In any case, more tests are always good, so please go ahead! Remember the tests should take only a few seconds and should not take up much disk space or runtime memory.
-
- changed status to open
- removed comment
I agree that test that tests most evolution parts but runs on a workstation (as compared to qc0) is very useful. Please apply (or most likely really just add the thorn to the thornlist).
-
reporter - changed status to resolved
- removed comment
Applied.
- Log in to comment