- changed status to open
- removed comment
Cactus allows for negative error level
Issue #1187
resolved
Currently, Cactus allows to set a negative error level through the command line option. This leads to CCTK_WARN(0,"") not necessarily aborting. While this is not wrong by itself, a lot of code assumes an abort at that point.
I propose to change CCTKi_SetErrorLevel() to only accept non-negative error levels and to change the command-parsing code to give an error message for that case as well. Patch is attached.
Keyword:
Comments (3)
-
reporter -
- changed status to open
- removed comment
Looks good. Please apply.
-
reporter - changed status to resolved
- removed comment
- Log in to comment