- changed status to open
- removed comment
remove poly_gamma_ini from EOS_Omni
eos omni uses this to compute (initially) conversion factors from code (assumed to e G=c=M_sun=1) to cgs units. It then goes back and forth between these units even for polytropic and gamma law eos. This is very confusing since poly_gamma_ini since poly_gamma_ini must mast poly_gamma and gl_gamma for a "usual" run with a Gamma law eos.
Keyword: EOS_Omni
Comments (6)
-
reporter -
- removed comment
This also relates to
#1070. The big question is: is someone actually using the parameter to set different EOS initially and for evolution? -
reporter - removed comment
I have to admit I am not even sure if this is what poly_gamma_ini does or if it is intended to do this. Certainly we have users setting it incorrectly. Also I would think that changing EOS from initial data to evolution is not something that the EOS thorn should do. Removing the parameter will loudly abort while leaving it in in the current fashion gives silently non-sensical results.
-
- changed status to open
- removed comment
Let's remove this parameter. Usually I would argue that we should not remove it completely but make it a dummy and complain if it is used. However, that is what (more or less) will happen anyway if the parameter is removed.
-
- removed comment
trigger.patch is applied
-
reporter - changed status to resolved
- removed comment
Thank you. Applied in rev 73 (eos_omni), rev 62 (refluxing) and rev 31 (trigger).
- Log in to comment