- changed status to resolved
- removed comment
Piraha's smart_ptr should be in namespace
Issue #1316
resolved
Piraha defines a helper class smart_ptr (and smart_ptr_guts). These should be located in a namespace.
Probably all of Piraha should be in the namespace cctk. As is, any user who tried to use Piraha in a thorn would be out of luck, since the name "piraha" is now globally already taken.
Keyword:
Comments (1)
-
reporter - Log in to comment
In addition to these type names there was also a global variable "ptrs".
I changed Piraha's namespace from "piraha" to "cctki_piraha", as per Cactus naming conventions.
I moved smart_ptr into this namespace as well.