- changed status to open
- removed comment
simfactory does not return "nice" error message when local rsync version cannot be determined
Issue #1394
resolved
currently, when the version of the local rsync executable cannot be determined (eg because the user has no executable privileges or because the regular expression did not match) the user is left with a python backtrace into lib/simlib.py/RsyncVersion stating that NoneType has no attribute groups.
The attached patch checks if the regular expression matched and if not reports a fatal error including rsync's return text in the error message.
Keyword:
Comments (3)
-
reporter -
- changed status to open
- removed comment
Approved.
No need for an else branch; fatal will not return.
-
reporter - changed status to resolved
- removed comment
applied as rev 2121 of simfactory.
I left the (superfluous) "else" in so that the code logic matches what is done in GetCactusFile (purely aesthetic).
- Log in to comment