- changed status to open
- removed comment
TOVSolver: do not set conservatives, remove TOV_Atmosphere
Issue #1405
resolved
the attached two patches remove TOV_Atmosphere[] from the code and do not set the conservative variables. Instead TOVSolver relies on GRHydro to set the conservatives in InitialPrim2Con and to enforce atmosphere in initialatmospherereset. This also fixes any asymmetry in atmosphere handling between the stars.
Most tests pass without change (since GRHydro ran anyway), the failing one being the test_two_av TOVSolver test which the second one regenerates. Differences are small but above threshold in the average case.
Keyword: TOVSolver
Comments (3)
-
reporter -
- changed status to open
- removed comment
The patch looks fine. Please apply
-
reporter - changed status to resolved
- removed comment
committed as revs 143 and 144 of TOVSolver.
- Log in to comment