- changed status to open
- removed comment
WALLTIME_HOURS incorrect
Issue #547
resolved
The SimFactory variable WALLTIME_HOURS should be expanded to the walltime of the job, not the walltime which was requested on the command line. If the user specifies more walltime than the queue allows, SimFactory splits the job into several restarts to give the total walltime requested. However, parameter files expect WALLTIME_HOURS to be the walltime of the job, not of the simulation.
Keyword:
Comments (3)
-
-
- removed comment
This patch seems correct. (The overall presubmission logic is a bit dodgy, though.) Please apply.
-
- changed status to resolved
- removed comment
Applied. Surprised to have commit rights for once :-)
- Log in to comment
This still happens, it renders simfactory's facility to automatically split a long run into a set of shorter chained runs useless. The attached patch fixes the incorrect walltime issue, not sure what other side effects it has.