- changed status to open
- removed comment
ML_ADMConstraints is incorrect
Issue #671
resolved
ML_ADMConstraints does not compute the constraints correctly. There are errors in the computation of the Ricci tensor. The attached patch corrects these errors. OK to apply?
Keyword: ML_ADMConstraints
Comments (5)
-
reporter -
- removed comment
Please apply.
In the BSSN equations, we improved the speed by introducing more local variables for some of the temporaries, instead of have many loops (bound indices) in the equations.
-
reporter - changed status to resolved
- removed comment
-
reporter - removed comment
I have also committed a fix to McLachlan_ADM where the error was repeated (probably it was copied from there originally). Do we need the constraints computed in both places?
-
- removed comment
I think ML_ADM does not need to compute the constraints.
- Log in to comment