Pull requests

#1 Declined
Repository
dkhenry dkhenry
Branch
default
Repository
ripencc ripencc
Branch
default

libbgpdump multi-process read safety

Author
  1. dkhenry
Reviewers
Description

Added a flock call to allow for safe reads of RIB files. Renamed int2str to avoid duplicate name errors. Fixed buffer overrun in int2str

Comments (1)

  1. Keelan Lightfoot

    I came across the same libmysqlclient clash, and the same flaw in int2str, however your fix doesn't go far enough. In the while loop, i-- is used to write to the string, over-writing the null terminator. I can't seem to find a way to check out your changes so that I can submit a fixed pull request, though.