Typo HelicopterHover.py
Issue #47
resolved
There seems to be an error in the default coefficients (line 88) in the helicopter hovering domain.
u_coeffs = np.array([-33.04, -33.32, 70.54, -42.15])
If you check other implementations (including the one this implementation is based off), the first coefficient is non-negative (i.e., u_coeffs[0] = 33.04). Is there a reason why this was changed or is it a typo?
Comments (2)
-
-
- changed status to resolved
fixes issue
#47, thanks Clement!→ <<cset 171b46b905e0>>
- Log in to comment
Thanks for spotting the typo, Clement! It is indeed inconsistent to the original implementation. However, as the actions are symmetric (there is always a negative action available for the agent to take), the sign flip should not affect the domain itself. Nevertheless, I will change the sign to make it consistent with other implementations. :-)