In Ride skill not used benefits from "One Body, One Soul" perk

[Karagy]

Subj. In other skills, the benefits from OBOS used correctly. For sample, in: Appraise, Craft, Healing, Winderness Lore, e.t.c. Craft just identical to Ride - "worst of WIS and DEX", but correct.

[Karagy]

It, seems, here: src/Create.cpp:

@@ -3925,18 +3925,18 @@ int16 Creature::ISkillLevel(int16 sk)
 int16 Creature::SkillAttr(int16 sk) {
     int8 attr1, attr2; 
     attr1 = SkillInfo[sk].attr1;
     attr2 = SkillInfo[sk].attr2;
     if (HasFeat(FT_ONE_BODY_ONE_SOUL) || (Attr[A_CON] == 0))  {
         if (Attr[A_WIS] > Attr[A_CON]) {
             if (attr1 == A_CON) attr1 = A_WIS;
-            if (attr2 == A_CON) attr1 = A_WIS;
+            if (attr2 == A_CON) attr2 = A_WIS;
         } else {
             if (attr1 == A_WIS) attr1 = A_CON;
-            if (attr2 == A_WIS) attr1 = A_CON;
+            if (attr2 == A_WIS) attr2 = A_CON;
         } 
     } 
     if (attr1 == attr2) 
         return attr1;
     else {
         if (SkillInfo[sk].take_min) 
             return Attr[attr1] > Attr[attr2] ? attr2 : attr1;

[RMTEW FULL NAME]

'One body, one soul' feat was intended to substitute best attribute value out of wisdom and constitution in some circumstances, but the code was wrong. Reported by Karagy, with patch. Fixes #186

→ <<cset e1ae96b44b9f>>