Commits

Robert Massaioli [Atlassian]  committed b60e0c1

CONNECT-255 - Responding to my own review comments.

I need to make sure, personally, that my changes make sense.

  • Participants
  • Parent commits e0cb25e
  • Branches CONNECT-225-jira-6.0-api-fixes

Comments (0)

Files changed (2)

File src/main/java/com/atlassian/jconnect/jira/IssueActivityService.java

                     JqlQueryBuilder.newClauseBuilder().
                     project().eq(project.getId()).and().
                     customField(uuidField.getIdAsLong()).eq().string(uuid).and().
-                    reporter().eq().string(user.getKey());
+                    reporter().eq().string(user.getUser().getName());
+            // In the previous line I used the username instead of the user key. This is why: https://answers.atlassian.com/questions/139810/jira-6-0-has-user-keys-should-we-be-using-user-keys-in-jql-instead-of-usernames-in-6-0
 
             final JqlClauseBuilder dateClause =
                     JqlQueryBuilder.newClauseBuilder().

File src/main/java/com/atlassian/jconnect/jira/IssueHelper.java

         // store the issue
         issueManager.createIssueObject(user.getUser(), issue);
 
-        log.debug(String.format("User %s created issue %s: %s", user.getKey(), issue.getKey(), issue.getSummary()));
+        log.debug("User {} created issue {}: {}", new Object[] {user.getKey(), issue.getKey(), issue.getSummary()});
 
         return issue;
     }
         FileUtils.copyFile(data.getInputStream(), attachmentFile, true);
         attachmentManager.createAttachment(attachmentFile, data.getFilename(), data.getContentType(), user.getUser(), issue);
 
-        log.debug(String.format("User %s attached %s to %s", user.getKey(), data.getFilename(), issue.getKey()));
+        log.debug("User {} attached {} to {}", new Object[] {user.getKey(), data.getFilename(), issue.getKey()});
     }
 
     public ErrorCollection updateIssue(MutableIssue issue, IssueEntity issueEntity, UserWithKey user) throws UpdateException {