zipio.open can return objects without context handlers in python 2

James Kruth avatarJames Kruth created an issue

In python 2, StringIO does not implement the context handler protocol. In py2app, calls to zipio.open assume that a context handler is present.

This is fairly easily fixed by doing a version check, and if on python 2, changing the following lines to:

84:    return contextlib.closing(_BytesIO(data))
90:    return contextlib.closing(_StringIO(data))

You'll of course have to import contextlib as well.

Comments (3)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.