Alex Szpakowski avatar Alex Szpakowski committed 324e70c

Fixed a potential memory leak

Comments (0)

Files changed (2)

src/modules/window/sdl/Window.cpp

 
 Window::~Window()
 {
+	if (currentMode.icon)
+		currentMode.icon->release();
+
 	SDL_QuitSubSystem(SDL_INIT_VIDEO);
 }
 
 
 bool Window::setWindow(int width, int height, graphics::Graphics *graphics, WindowFlags *flags)
 {
-
 	if (graphics)
 		graphics->unSetMode();
 
 
 love::image::ImageData *Window::getIcon()
 {
-	if (currentMode.icon)
-		currentMode.icon->retain();
-
 	return currentMode.icon;
 }
 

src/modules/window/wrap_Window.cpp

 {
 	image::ImageData *i = instance->getIcon();
 	if (i)
+	{
+		i->retain();
 		luax_newtype(L, "ImageData", IMAGE_IMAGE_DATA_T, (void*) i);
+	}
 	else
 		lua_pushnil(L);
 	return 1;
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.