Issue #4 new

can't use translation strings as tag arguments

jerzyk avatarjerzyk created an issue

current evaluation of variables prohibit use of Django's translations:

{% menu_item "/foo/" _("Foo") %}

I suggest to follow django's path and use template.Variable approach, first replace initialization of variables in __init__:

self.url = template.Variable(url)
self.text = template.Variable(text)
self.classes = template.Variable(classes) if classes else None

then in the render function, resolve those variables against context:

url = self.url.resolve(context)
text = self.text.resolve(context)
if self.classes:
    classes = self.classes.resolve(context)
else:
    classes = u''

this will allow to use translations and variables in place of each argument, as well it will save us from parsing strings (check is there is " or ' as the first char).

Comments (2)

  1. Matthew Schinckel

    The example you provide goes against django's template tag syntax: function calls are generally not permitted in template tags.

    How is this type of thing done in other situations?

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.