Anonymous avatar Anonymous committed 6f2c63b

Don't blindly set the value, delete it if it exists instead. Otherwise you negatively impact your cache hit count.

Comments (0)

Files changed (1)


         context['openid_provider'] = request.session.get('openid_provider', '')
         # clear the error once it's been displayed once
-        request.session['openid_error'] = ''
-        request.session['openid_provider'] = ''
+        if request.session.get('openid_error', False):
+            del request.session['openid_error']
+        if request.session.get('openid_provider', False):
+            del request.session['openid_provider']
         return u''
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.