ServiceDiscoveryManager.discoverServices() no longer searches server jid

[Daniel Gultsch]

Somewhere between 0.8 and master ServiceDiscoveryManager.discoverServices(String namespace) has lost the ability to find services hosted on the server domain instead of one of the items.

Some prosody configurations (for example) host http upload on the server domain instead of an extra item. Since discoverServices() no longer finds those cases finding http upload has become more complicated in that I have to run discoverServices and discoverInformation(domain).

[Christian Schudt]

Hm, the only relevant change I could find with regards to service discovery was for issue #146, where only the 'var' attribute is checked to be non-null. I doubt it's related to this issue, but maybe you have an idea. Or do you have more raw XMPP traffic, so that I can check?

[Daniel Gultsch]

Ah sorry I tricked myself. I was using a custom implementation of discoverServices() (due to the older NPE bug (#77) and then removed that custom implementation and updated from 0.7.4 to master at the same time. That custom implementation was also searching the domain for features not just the items.

I’m closing here. Yet it might be worth for discoverServices to search the domain as well (instead of just the items) to for example find HTTP upload services hosted on the server domain. (Especially in regards to your recent work on that.)

(Yes yes i agree that hosting it on the server domain isn’t necessarily a good idea yet it is a configuration that Prosody allows and many admins use (knowingly or not))