Making AvatarManager non-final to allow subclassing as AwtAvatarManager vs FxAvatarManager

Issue #39 wontfix
Markus KARG created an issue

I just had this idea and thought it might be pretty cool to solve the AWT vs FX vs byte[] discussion in AvatarManager: We could simply make AvatarManager and non-final, which opens the possibility for me to implement an AwtAvatarManager subclass. That one provides nothing but the Image-to-byte[] conversions. Also the events fired by its listeners are of different type (Image vs byte[]). That makes the AvatarManager AWT-free, but provides exactly what I need.

In future we could even add FxAvatarManager, which does the same but simply with FX images.

Maybe this is what you like more? Just drop me a note if you want me to implement that instead of having AWT Image inside of AvatarManager.

Comments (1)

  1. Christian Schudt repo owner

    As per our discussion this has been solved by using java.awt.Image directly instead of subclassing.

  2. Log in to comment