No access to Rtp.PayloadTypes

[dave ertel]

I've looked around quite a bit for a java xmpp library, babbler looks to be a well written and documented implementation. Thank you for developing it. A question and possible enhancement which I'd be happy to contribute to... In rocks.xmpp.extensions.jingle.apps.rtp.model, Rtp declares payloadTypes as final and an empty list. Is there a reason that there is no way to set the PayloadTypes for an Rtp object? I can create custom Rtp.PayloadTypes but there is no way to add them to the Rtp object. I am using the babbler models to manually create jingle packets for my clients and I need the ability to set custom PayloadTypes for each Content type of "audio" and "video" in the Jingle message. Was there another way that you had in mind to set the PayloadTypes? Thank you for your contributions to java/xmpp and your response.

[Christian Schudt]

Hi,

admittedly most of the Jingle code has never really developed to the end and needs more love. There are only the basic building blocks, i.e. XMPP schema implementations like Rtp class.

Actually there's a

public List<PayloadType> getPayloadTypes()

which you could use to add your payload type, can't you?

Actually, I'd even prefer to pass the payload types in a constructor and make the List unmodifiable (because every other class in the library works this way too), but the constructor is currently unavailable.

I might need to have a second look at the Jingle classes.

[dave ertel]

Ok reread that code a bit, it makes sense now what you were saying. Too many late nights working on stuff...

[dave ertel]

A setter isn't really needed for this. getPayloadTypes() is sufficient to do what I need.