Anonymous avatar Anonymous committed 3d05a28

Fix ARGUMENTS specifications on the command line that have multiple = in them. (Zephaniah Hull)

Comments (0)

Files changed (3)

     of them from cache, not just the first target, and exec the build
     command if any of the targets isn't present in the cache.
 
+  From Zephaniah Hull:
+
+  - Fix command-line ARGUMENTS with multiple = in them.
+
   From Steven Knight:
 
   - Fix EnsureSConsVersion() so it checks against the SCons version,

src/engine/SCons/Script/SConscript.py

 
 def _scons_add_args(alist):
     for arg in alist:
-        a, b = string.split(arg, '=', 2)
+        a, b = string.split(arg, '=', 1)
         Arguments[a] = b
 
 def _scons_add_targets(tlist):

test/ARGUMENTS.py

 foo.close()
 """)
 
-test.run(arguments='a=1 bz=3 xx=sd .')
+test.run(arguments='a=1 bz=3 xx=sd zzz=foo=bar .')
 
 test.fail_test(test.read('foo.out') != """a = 1
 bz = 3
 xx = sd
+zzz = foo=bar
 """)
 
 test.pass_test()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.