Commits

Anonymous committed c36d9be

Delay any creation of DefaultEnvironment() until after the SConscript files are read.

Comments (0)

Files changed (2)

src/engine/SCons/Node/FS.py

     global MkdirBuilder
     if MkdirBuilder is None:
         import SCons.Builder
-        import SCons.Defaults
-        env = SCons.Defaults.DefaultEnvironment()
+        # "env" will get filled in by Executor.get_build_env()
+        # calling SCons.Defaults.DefaultEnvironment() when necessary.
         MkdirBuilder = SCons.Builder.Builder(action = Mkdir,
-                                             env = env,
+                                             env = None,
                                              explain = None)
     return MkdirBuilder
 
     global DefaultSCCSBuilder
     if DefaultSCCSBuilder is None:
         import SCons.Builder
-        import SCons.Defaults
+        # "env" will get filled in by Executor.get_build_env()
+        # calling SCons.Defaults.DefaultEnvironment() when necessary.
         DefaultSCCSBuilder = SCons.Builder.Builder(action = '$SCCSCOM',
-                                                   env = SCons.Defaults.DefaultEnvironment())
+                                                   env = None)
     return DefaultSCCSBuilder
 
 def get_DefaultRCSBuilder():
     global DefaultRCSBuilder
     if DefaultRCSBuilder is None:
         import SCons.Builder
-        import SCons.Defaults
+        # "env" will get filled in by Executor.get_build_env()
+        # calling SCons.Defaults.DefaultEnvironment() when necessary.
         DefaultRCSBuilder = SCons.Builder.Builder(action = '$RCS_COCOM',
-                                                  env = SCons.Defaults.DefaultEnvironment())
+                                                  env = None)
     return DefaultRCSBuilder
 
 #

test/ConstructionEnvironment.py

+#!/usr/bin/env python
+#
+# __COPYRIGHT__
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
+# KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
+# WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#
+
+__revision__ = "__FILE__ __REVISION__ __DATE__ __DEVELOPER__"
+
+"""
+Test that setting values in SCons.Defaults.ConstructionEnvironment
+will, in fact, affect the DefaultEnvironment() that's created.
+"""
+
+import TestSCons
+
+test = TestSCons.TestSCons()
+
+test.write('SConstruct', """
+import SCons.Defaults
+SCons.Defaults.ConstructionEnvironment.update({
+        'XXX'   : 777,
+})
+print DefaultEnvironment()['XXX']
+""")
+
+expect = test.wrap_stdout(read_str = "777\n",
+                          build_str = "scons: `.' is up to date.\n")
+
+test.run(arguments = '.', stdout = expect)
+
+test.pass_test()