Pull requests

#102 Declined
Repository
dirkbaechle dirkbaechle
Branch
default
Repository
scons scons
Branch
default

Disabling reset of Node attributes in built() during interactive mode...

Author
  1. dirkbaechle
Reviewers
Description

Based on the latest findings and error reports from Roberto de Vecchi and Gary, I propose to disable the additional reset of Node attributes in the built() method during Interactive mode.

This effectively means that we'll only see a memory reduction for clean builds and update runs...but it's better to play it safe, so short to the 2.3.1 release.

Dirk

  • Learn about pull requests

Comments (2)

  1. Gary Oberbrunner

    I was just reviewing pull requests, and on this one, bitbucket said there were new changes that should be added and I should update it -- so I did. But I think that made it pull in an unrelated change. I assume I should just pull 03f0d17 and not yet 431f171.