Pull requests

#81 Declined
Repository
Deleted repository
Branch
win7vs11 (19a5828d1523)
Repository
scons/SCons SCons
Branch
default

fix for visual studio expres on win7 x86_64

Author
  1. Antonio Cavallo
Reviewers
Description

While using scons on win7 (64bits) using visual studio express 11 I got the error message (see the end of this message).

I believe this is due to the _sdk.get_sdk_vc_script returning a None value: this patch check for this case and return the appropriate value.

scons: Reading SConscript files ...
TypeError: 'NoneType' object has no attribute '__getitem__':
  File "C:\Users\antonio\Projects\cpython\fatpython\SConstruct", line 133:
    ''')
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Script\SConscript.py", line 607:
    env = self.factory()
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Script\SConscript.py", line 587:
    default_env = SCons.Defaults.DefaultEnvironment()
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Defaults.py", line 88:
    _default_env = SCons.Environment.Environment(*args, **kw)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Environment.py", line 1002:
    apply_tools(self, tools, toolpath)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Environment.py", line 106:
    env.Tool(tool)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Environment.py", line 1786:
    tool(self)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\__init__.py", line 183:
    self.generate(env, *args, **kw)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\default.py", line 41:
    SCons.Tool.Tool(t)(env)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\__init__.py", line 183:
    self.generate(env, *args, **kw)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\mslink.py", line 303:
    msvc_setup_env_once(env)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\MSCommon\vc.py", line 366:
    msvc_setup_env(env)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\MSCommon\vc.py", line 473:
    d = msvc_find_valid_batch_script(env,version)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\MSCommon\vc.py", line 407:
    (vc_script,sdk_script) = find_batch_file(env,version,host_platform,tp)
  File "C:\Users\antonio\Projects\cpython\fatpython\scons\SCons\Tool\MSCommon\vc.py", line 274:
    sdk_bat_file_path=os.path.join(pdir,sdk_bat_file)
  File "C:\Python27\lib\ntpath.py", line 73:
    elif isabs(b):
  File "C:\Python27\lib\ntpath.py", line 57:
    s = splitdrive(s)[1]
  File "C:\Python27\lib\ntpath.py", line 125:
    if p[1:2] == ':':

Comments (0)