Pull requests

#4 Merged
Repository
Deleted repository
Branch
default (54400c844297)
Repository
scons/SCons SCons
Branch
default

Fix 2 uses of names that don't exist

Author
  1. Richard Quirk
Reviewers
Description

Here are a couple of bug fixes for error paths that use undefined variables. Looks like they were copy-paste errors.

I couldn't find a test case that triggered the incorrect use of "UserError".

  • Learn about pull requests

Comments (2)

  1. SCons repo owner

    Do you have test case(s) which cause SCons to fail? In general new code requires tests to ensure we don't break those issues fixed in the future.

  2. Richard Quirk author

    For type_name the patch already includes an update to the test (SConfTests.py). For the UserError fix, I think it is impossible to actually go down that branch of code, since _generate already checks for falseyness.