Error while editing location names

[Adam Winer]

just got this message while changing the spelling of a location that I had already entered sightings for.

ndex -1 out-of-bounds for length 5

java.lang.IndexOutOfBoundsException: Index -1 out-of-bounds for length 5

at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)

at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)

at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)

at java.base/java.util.Objects.checkIndex(Objects.java:372)

at java.base/java.util.ArrayList.get(ArrayList.java:440)

at .ui.panels.location.LocationTreeModel.getChild(LocationTreeModel.java:74)

at java.desktop/javax.swing.tree.VariableHeightLayoutCache.createNodeAt(VariableHeightLayoutCache.java:778)

at java.desktop/javax.swing.tree.VariableHeightLayoutCache.treeNodesInserted(VariableHeightLayoutCache.java:490)

at java.desktop/javax.swing.plaf.basic.BasicTreeUI$Handler.treeNodesInserted(BasicTreeUI.java:4284)

at .ui.util.BaseTreeModel.fireTreeNodesInserted(BaseTreeModel.java:52)

at .ui.panels.location.LocationTreeModel.newLocation(LocationTreeModel.java:142)

at .ui.panels.location.LocationBrowsePanel.updateTreeForNewPath(LocationBrowsePanel.java:894)

at .ui.panels.location.LocationBrowsePanel.access$1600(LocationBrowsePanel.java:153)

at .ui.panels.location.LocationBrowsePanel$7.newVisitInfoKey(LocationBrowsePanel.java:426)

at .ui.panels.reports.ReportsBrowserPanel.replaceVisitInfoKey(ReportsBrowserPanel.java:689)

at .ui.components.BaseTaxonBrowserPanel$TaxonPreviewRenderer$1.visitInfoUpdated(BaseTaxonBrowserPanel.java:750)

at .ui.components.VisitInfoBrowsePanel.save(VisitInfoBrowsePanel.java:296)

at .ui.components.VisitInfoBrowsePanel.access$000(VisitInfoBrowsePanel.java:55)

at .ui.components.VisitInfoBrowsePanel$1.actionPerformed(VisitInfoBrowsePanel.java:138)

[scythebill]

Resolve Issue #557: Error while editing location names

I ... don't know if this really does resolve it. Underlying scenario looks to be that a user was editing VisitInfo, and created a new location while in there, and the LocationTreeModel code for handling this got handed odd state. Don't know why this happens, but for now just adding defensive code.

→ <<cset a5873f859717>>

[scythebill]

Really(?) Resolve Issue #557: Error while editing location names

Fix a glitch with creating locations while "Only visited locations?" is selected.

→ <<cset 617092bd0e96>>