Issue #176 resolved

Add ability for owner and administrator to modify hgrc through web interface

created an issue

It would be really useful to be able to modify the .hg/hgrc, .git/config, and conf/svnserve.conf files through the web interface.

Comments (10)

  1. Sebastian Sdorra repo owner

    Please keep in mind that SCM-Manager is for Git, Mercurial and Subversion. Functions which are special to one of them must be placed in a extra plugin and they will never be part of the core. But i will write a extra plugin for this, if i have the time or it is possible that you write a plugin by yourself (i would help with the basic structure)?

  2. DRayX reporter

    Ya, I wasn't trying to be particularly specific to mercurial, more so I was trying to convey that the ability to set per repository configurations (like .hg/hgrc and .git/config) would be useful. I suppose I also should have listed conf/svnserve.conf, but I couldn't remember the name of it. All three of these are ini files used to configure the repository, but right now to modify them the only option is to ssh (or rdp) into the system and modify the files. I could definitely look into writing a plugin for the hgrc, but it has been a while since I have done java. I will look at the example plugin and see where I can get from there.

  3. Sebastian Sdorra repo owner

    hi corux and thanks for your work. But modifying the configurations is very dangerous, if everyone removes one of the lines from the mercurial config, the repository will be broken.

    I've looked at the plugin and there are some small bugs to fix:

    • The WebConfigResource is accessible from every user which has read permissions for the repository. I think the resource should only be accessible for owners and administrators.
    • You have to close the RepositoryService in a final block, because it frees resources. In the case of mercurial a python process is running until you close the repository service.
  4. corux

    Thanks for your feedback! I've fixed the bugs and pushed it to github. Additionally, a confirm dialog is now displayed before saving.

  5. Log in to comment