1. Sebastian Sebastian
  2. scm-manager
  3. Issues

Issues

Issue #19 resolved

SCM Manager not using HTML Encode

Anonymous created an issue

I tried to use my Email Adress as user like test@test.com

When I try to clone

git clone http://test%40test.com@home.com

the http string is not decoded in test@test.com

In this case it's not possible to user email as user name in the tool

Comments (11)

  1. Anonymous

    Same problem exists with a '!' in the password for example in case you try to use

    git clone http.user:password@home.com/git in case your password is !gittest the password should be %23gittest because :!gittest@ is not working.

  2. Sebastian Sebastian repo owner

    I could not reproduce this issue. I've tested on Mac and on Windows:

    C:\Users\sdorra>git clone http://test%40scm-manager.org@localhost:8080/scm/git/test
    Cloning into test...
    Password:
    remote: Counting objects: 8, done
    remote: Finding sources: 100% (8/8)
    remote: Total 8 (delta 2), reused 8 (delta 2)
    Unpacking objects: 100% (8/8), done.
    
    C:\Users\sdorra\test>git push http://test%40scm-manager.org@localhost:8080/scm/git/test master
    Password:
    Counting objects: 8, done.
    Compressing objects: 100% (7/7), done.
    Writing objects: 100% (8/8), 1.40 KiB, done.
    Total 8 (delta 2), reused 0 (delta 0)
    remote: Resolving deltas: 100% (2/2)
    To http://test%40scm-manager.org@localhost:8080/scm/git/test
     * [new branch]      master -> master
    
  3. scm_manager_tester

    For me it looks like that:

    git clone https://test%40test.de@localhost:8181/scm/git/test tester Initialized empty Git repository in C:/Users/.... Password: error: The requested URL returned error: 401 while accessing https://test%40test .de@localhost:8181/scm/git/test/info/refs

    and from scm-server.bat: 10:01:04.511 [qtp16399041-18] DEBUG sonia.scm.web.security.XmlAuthenticationHandler - could not find user test%40test.de 10:01:04.511 [qtp16399041-18] DEBUG sonia.scm.web.security.ChainAuthenticatonManager - authenticator sonia.scm.web.security.XmlAuthenticationHandler e nds with result, user: null, state: NOT_FOUND 10:01:04.980 [qtp16399041-18] DEBUG sonia.scm.web.security.ChainAuthenticatonManager - authenticator sonia.scm.auth.ldap.LDAPAuthenticationHandler end s with result, user: null, state: NOT_FOUND

    SCM Manager is running on Windows

  4. Sebastian Sebastian repo owner

    My test was on windows too, which version of git do you use? I think that is not a problem of the scm-manager, because the client (in this case git) must parse the url and create a basic-auth-header of the given username and password.

  5. Log in to comment