Better error msg during second pull request

Issue #491 resolved
André Klitzing created an issue

Hi,

I'm using the fork-plugin and I get an "unknown error" on pull requests. There should be a better error message if there is an open pull request. :-)

Steps: 1. Create a fork of a repository 2. Change something (commit / push) 3. Send a pull requests. 4. Try to send another pull request from same repository 5. You will get an UNKNOWN ERROR message.

Expected: A nice error message that there is still a open pull request.

Stacktrace:

12:44:06.052 [http-bio-8080-exec-15] WARN  sonia.scm.fork.PullRequestResource - could not create pull request
   sonia.scm.fork.PullRequestAlreadyOpenException: there is already a open pull request: 8UOOa1es14
     at sonia.scm.fork.PullRequestService.checkCreateable(PullRequestService.java:477) ~[scm-fork-plugin-1.1.jar:na]
     at sonia.scm.fork.PullRequestService.create(PullRequestService.java:225) ~[scm-fork-plugin-1.1.jar:na]
     at sonia.scm.fork.PullRequestResource.create(PullRequestResource.java:146) ~[scm-fork-plugin-1.1.jar:na]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.7.0_45]

Comments (3)

  1. Log in to comment