1. Sebastian Sebastian
  2. scm-manager
  3. Pull requests

Pull requests

#10 Declined
Repository
tavise
Branch
default
Repository
sdorra
Branch
default

Added bookmarks to Changeset.

Author
  1. Tavis Elliott
Reviewers
Description

Unit tests appear to pass, I haven't stood up a server yet, as I don't know how to validate it's doing it correctly without the notify plugin.

As soon as this is merged I can update the notify plugin to depend on the latest version and add bookmarks to the email! Yay.

Comments (5)

  1. Sebastian Sebastian repo owner

    Bookmarks are very mercurial specific and should not be directly in the Changeset class. I think a better approach is to store the bookmarks as property of the changeset.

  2. Tavis Elliott author

    (Sorry I've been really busy on other things)

    I don't see much difference between changeset.getProperty( Changeset.HG_BOOKMARKS ) vs changeset.getHgBookmark() other than the former being more verbose and error-prone.

    Would it be acceptable to change the method to getHgBookmarks() instead of getBookmarks()?

  3. Sebastian Sebastian repo owner

    No, this would not be acceptable. Because all classes of scm-core must be independent of mercurial specific stuff, even Changeset.HG_BOOKMARKS would be not acceptable.