TUtils.TryConvert will convert from a value to a Nullable Type, but not from a Nullable Type to a value

We are using the Persistence.TUtils.TryConvert method in our own code to convert TValues from a given value type such as String or Integer to their Nullable equivelant and it works great.

Today I tried to use this same function in the reverse and it failed to convert. After looking at the code I can see that the reverse circumstance is not coded in this method. Should it Be? Or is there another method we should be using to convert from a NullableType to it's underlying value type?

class function TUtils.TryConvert(const AFrom: TValue; targetTypeInfo: PTypeInfo; AEntity: TObject; var AResult: TValue): Boolean;
var
  freeAfterUse: Boolean;
begin
  if AFrom.TypeInfo <> targetTypeInfo then
  begin
    case targetTypeInfo.Kind of
      tkRecord:
      begin
        if IsNullable(targetTypeInfo) then
        begin
          TValue.Make(nil, targetTypeInfo, AResult);
          AResult.SetNullableValue(AFrom);
          Exit(True);
        end else
        if TType.IsLazyType(targetTypeInfo) then
        begin
          //AFrom value must be ID of lazy type
          if AFrom.IsEmpty then
            raise EORMColumnCannotBeNull.Create('Column for lazy type cannot be null');
          Exit(True);
        end;
      end;
    end;
    {TFlora - ADDED THE FOLLOWING CODE TO CONVERT FROM NULLABLE TYPE TO SOMETHING ELSE}
    if (AFrom.TypeInfo.Kind = tkRecord) then
    begin
      if IsNullable(AFrom.TypeInfo) then
      begin
        TValue.Make(nil, targetTypeInfo, AResult);
        Exit(AFrom.TryGetNullableValue(AResult));
      end
    end;
   {TFlora - done with code addition}

    freeAfterUse := False;
    Result := Spring.Persistence.Core.Reflection.TryConvert(AFrom, targetTypeInfo, AResult, freeAfterUse);
  end
  else
  begin
    Result := True;
    AResult := AFrom;
  end;
end;

Comments (7)