1. shemnon
  2. javafx-gradle

Pull requests

#1 Merged
Repository
Deleted repository
Branch
master (fb8aff2516aa)
Repository
javafx-gradle
Branch
master

Added some missing flags, that I needed for my app, in the jfxDeploy task: offlineAllowed, updateMode, codebase, and all the shortcut icon properties

Author
  1. Gabriel Féron
Reviewers
Description

Just a quick fix to add some missing properties I desperately needed in the generated JNLP file. If you want, I can map all the properties you didn't have the time to add. Just tell me and I'll do it ASAP.

Thanks for the plugin!

  • Learn about pull requests

Comments (8)

  1. shemnon repo owner

    I think the core issue is that we must still support Java 7 until Java 8 is released. codebase is not in the Java 7 DeployParams.

  2. shemnon repo owner

    If we identify the invalid params we can wrap it in a try/catch (it's groovy after all) and complain to the user that those params are not supported in Java 7.