1. Shlomi Fish
  2. Fiction-XML

Commits

Author Commit Message Date Builds
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Restructred the ->_short_isa_ call, so the func will be easier to modify. This is part of the ongoing refactorings of the FromProto modules.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a method in order to merge it.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract the _write_Element_elem method from both classes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a method - _paragraph_tag() to abstract differences in classes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a common base class - XML/Grammar/FictionBase/TagsTree2XML .
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Add a commented isa for debugging (per #moose).
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Convert Screenplay::FromProto to _short_isa in order to normalise.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract _main_loop_iter_body_prelude .
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract the _main_loop_iter into XmlIterator. We defined another function - _main_loop_iter_body with the specialised logic.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Create _check_and_handle_tag_event with a loop over the tag names.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Renamed two methods to make them more consistent.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Renamed _handle_paragraph_event to _handle_para_event to make it more consistent.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract is_open().
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Convert the ${event}S field accesses to accessors.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a class for the event objects. TODO : convert all direct field dereferences (e.g: $event->{type}) to accessor calls.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved _handle_open_tag to the XmlIterator base class.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a base class method.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved _generate_tag_event to the base class and extracted it from Screenplay.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved _parse_text_unit to the base XmlIterator class.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Merged _parse_non_tag_text_unit into XmlIterator.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Got rid of the duplicate Test-Pod and Test-Pod-Coverage tests. This may make running the tests suite somewhat faster.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved an unused subroutine to the rejects.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Merged _parse_text upwards.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Removed the functions for real this time - forgot to save the file. :-S.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved some unused functions to the rejects.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Convert a field access to an accessor.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Merged up _parse_closing_tag into Parser::XmlIterator
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved _parse_opening_tag to the XmlIterator base class. This involved inheriting from it in the Screenplay class.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Made the inheritance graph saner.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Moved _new_comment to ::XmlIterator.
  1. Prev
  2. Next