1. Shlomi Fish
  2. Fortune-XML

Commits

Show all
Author Commit Message Date Builds
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Bumped the version number, updated the Changes and add a dependency. The dependency is on XML-Grammar-Fortune-0.0400 which will hopefully make this module not fail its tests.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Add MANIFEST.SKIP and added MYMETA.yml to the svn:ignore.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Reformated the Changes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Removed trailing space from Changes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Tagging the XML-Grammar-Fortune release as 0.0400
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Add the date to the changes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Bump the version number to 0.0400.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Update Changes.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: moved an unused method to the rejects. And r4567 ! A sequence.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Converted to use File::ShareDir for the extradata directory. This was done per the advice given here: 1. http://www.nntp.perl.org/group/perl.module.build/2010/10/msg2765.html .
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: extract a method - _get_formatted_node_text.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: _render_info_node now accepts $info_node instead of $fortune_node.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Got rid of the _fortune slot. Now we passing the value from function to function.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactored _handle_screenplay_portion .
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a common functionality from two if clauses.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Now one can pass a method name to _iterate_on_child_elems. Methods in three places - only one callback left.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactored.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: extract two long methods from the _iterate_on_child_elems callbacks.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Changed _iter_over_elems_list to _iterate_on_child_elems . It now accepts a parent element and an XPath expression to generate the list. This was common in all the calls.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Removed assignments of the lists.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: extract _iter_over_elems_list(). This is an abstracted loop construct to iterate over a list of XML elements, with process, if_more and an optional continue callback.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Refactoring: extract a method - _output_next_fortune_delim. This is as a stepping stone to abstracting the $nodes_list->shift / ->size() loops.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract _render_single_fortune_cookie .
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Put a common call in each dispatched method outside the dispatch.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
$raw_node -> $node.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Convert a switch statement to method dispatch.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a common method.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Renamed info to info_node to make it more descriptive.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract _get_info_node_fields.
shl...@52c325ad-5fd0-0310-8a0f-c43feede02cc
Extract a method.
  1. Prev
  2. Next