Commits

shl...@6f433eb9-a002-0410-945b-ee5462c261ee  committed d3bfe11

Moved some PODed out functions under rejects/ .

  • Participants
  • Parent commits 10f7ffd

Comments (0)

Files changed (4)

     the conditions clearer.
     - Optimization: now compiling the _check_subdir_helper function
     by eval ""'ing it because it contains many conditions that depend
-    on instance-wide and constant parameters. 
+    on instance-wide and constant parameters.
+    - Cleanup: moved some POD'ed out functions to under rejects/ .
 
 0.1.7 - Thu Jan 15 16:09:49 IST 2009
     - Fixed the check-for-link and for directory semantics on Windows
 MANIFEST			This list of files
 META.yml            Module meta-data (added by MakeMaker)
 README
+rejects/File/Find/Object.pm
 t/01ffo.t
 t/02tree-create.t
 t/03traverse.t

File lib/File/Find/Object.pm

     return $tree;
 }
 
-#sub DESTROY {
-#    my ($self) = @_;
-#    print STDERR join(" ", caller)."\n";
-#    printf STDERR "destroy `%s'\n", $self->_dir_as_string || "--";
-#}
-
-=begin Removed
-
-# We're removing this because it's no longer used, but may be used in the
-# future.
-
-sub _is_top
-{
-    my $self = shift;
-
-    return ! exists($self->{_st});
-}
-
-=end Removed
-
-=cut
-
 sub _curr_not_a_dir {
     return !shift->_top_is_dir();
 }
     return $self->item_obj() ? $self->item_obj()->path() : undef;
 }
 
-=begin Removed
-
-This function is no longer used.
-
-sub _father
-{
-    my ($self, $level) = @_;
-
-    if ($level->idx() == 0)
-    {
-        return undef;
-    }
-    else
-    {
-        return $self->_dir_stack()->[$level->idx()-1];
-    }
-}
-
-=end Removed
-
-=cut
-
 sub _current_father {
     return shift->_dir_stack->[-2];
 }
     }
 }
 
-=begin Removed
-
-This code was removed to be replaced with the eval ""-ed code.
-
-sub _check_subdir_helper_t {
-    return 1;
-}
-
-sub _check_subdir_helper_d {
-    my $self = shift;
-
-    return
-    !(
-        (!$self->followlink() && $self->_top_is_link())
-            ||
-        ($self->nocrossfs() && $self->_top_stat->[0] != $self->_dev())
-            ||
-        ($self->_is_loop())
-     )
-     ;
-}
-
-=end Removed
-
-=cut
-
 # We eval "" the helper of check_subdir because the conditions that
 # affect the checks are instance-wide and constant and so we can
 # determine how the code should look like.

File rejects/File/Find/Object.pm

+use strict;
+use warnings;
+
+# We're removing this because it's no longer used, but may be used in the
+# future.
+
+sub _is_top
+{
+    my $self = shift;
+
+    return ! exists($self->{_st});
+}
+
+# This function is no longer used.
+
+sub _father
+{
+    my ($self, $level) = @_;
+
+    if ($level->idx() == 0)
+    {
+        return undef;
+    }
+    else
+    {
+        return $self->_dir_stack()->[$level->idx()-1];
+    }
+}
+
+# This code was removed to be replaced with the eval ""-ed code.
+
+sub _check_subdir_helper_t {
+    return 1;
+}
+
+sub _check_subdir_helper_d {
+    my $self = shift;
+
+    return
+    !(
+        (!$self->followlink() && $self->_top_is_link())
+            ||
+        ($self->nocrossfs() && $self->_top_stat->[0] != $self->_dev())
+            ||
+        ($self->_is_loop())
+     )
+     ;
+}
+