Shlomi Fish avatar Shlomi Fish committed 0bc5ccc

Less monolithic trailing ifs.

Comments (0)

Files changed (1)

lib/Parser/MGC.pm

    my $self = shift;
    my ( $sep, $code ) = @_;
 
-   ref $sep or $sep = qr/\Q$sep/ if defined $sep;
+   # Convert $sep into a regular expression in case it is a string.
+   if (defined $sep and !ref $sep) {
+       $sep = qr/\Q$sep/;
+   }
 
    my $committed;
    local $self->{committer} = sub { $committed++ };
       my $e = $@;
 
       pos($self->{str}) = $pos;
-      die $e if $committed or not eval { $e->isa( "Parser::MGC::Failure" ) };
+      if ($committed or not eval { $e->isa( "Parser::MGC::Failure" ) }) {
+          die $e;
+      }
       last;
    }
    continue {
       local $self->{committer} = sub { $committed++ };
 
       my $ret;
-      eval { $ret = shift->( $self ); 1 } and return $ret;
+      if (eval { $ret = shift->( $self ); 1 }) {
+          return $ret;
+      }
       my $e = $@;
 
       pos( $self->{str} ) = $pos;
 
-      die $e if $committed or not eval { $e->isa( "Parser::MGC::Failure" ) };
+      if ($committed or not eval { $e->isa( "Parser::MGC::Failure" ) }) {
+          die $e;
+      }
    }
 
    $self->fail( "Found nothing parseable" );
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.